Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker phpcs command and improve readme #237

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Fix docker phpcs command and improve readme #237

merged 4 commits into from
Sep 30, 2021

Conversation

AlexP11223
Copy link
Contributor

  • Fixed docker phpcs command (copy-pasted wrong option).
  • Improved style consistency of some commands in readme and made the package building section more clear (order of steps).
  • Updated the build command to use yarn like other commands, to not require npm installation for no reason.

@AlexP11223 AlexP11223 requested a review from Dinamiko August 30, 2021 14:27
@Dinamiko Dinamiko merged commit c00c581 into trunk Sep 30, 2021
@Dinamiko Dinamiko deleted the fix-cmd branch September 30, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinamiko Dinamiko Dinamiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexP11223 @Dinamiko